Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expandable show notes to watch episode screen #871

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Apr 6, 2023

Description

Adds an expandable section for the show notes to the episode details screen on the watch.

This is converting the HTML show notes into plain text. This seemed like the best way to deal with this for now since web views are not supported on Wear OS. This does mean that links and other HTML elements are basically not rendered, but I think this implementation is better than nothing and it's something we can address later if it proves to be a problem (I'm skeptical that many will be doing much reading of long show notes on their watch, but maybe I'm wrong).

Testing Instructions

  1. Go to the episode details screen
  2. Scroll down and observe that the show notes displays at most three lines and (assuming there is more than 3 lines), there is a gradient fading out the text toward the bottom
  3. Tap on the show notes
  4. Observe the notes expand
  5. Tap on the show notes again
  6. Observe that the notes collapse. If you had scrolled down quite a ways in the show notes, when collapsing them the list should scroll to ensure that the collapsed scroll notes are still visible (as opposed to the scroll position remaining at the bottom of the list). I have noticed that sometimes there is a bit of a jump with this on my emulator, but it doesn't seem to occur on my physical device.

Screenshots or Screencast

device-2023-04-06-174133.webm

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning added the [Area] Wear OS watch app label Apr 6, 2023
@mchowning mchowning requested a review from a team as a code owner April 6, 2023 21:43
@ashiagr
Copy link
Contributor

ashiagr commented Apr 7, 2023

Since Wear OS does not support using WebView, I agree it is better to show plain text for now.

The text expands and collapses well in my testing. Nice job getting this added!

@ashiagr ashiagr merged commit d3f3a51 into main Apr 7, 2023
@ashiagr ashiagr deleted the add/show-notes-to-watch branch April 7, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants