Add watch settings screen with metered data warning #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
commented
Apr 1, 2023
Comment on lines
+72
to
+83
| // Listen for results from streaming confirmation screen | ||
| navController.currentBackStackEntry?.savedStateHandle | ||
| ?.getStateFlow<StreamingConfirmationScreen.Result?>(StreamingConfirmationScreen.resultKey, null) | ||
| ?.collectAsStateWithLifecycle()?.value?.let { streamingConfirmationResult -> | ||
| val viewModel = hiltViewModel<NowPlayingViewModel>() | ||
| LaunchedEffect(streamingConfirmationResult) { | ||
| viewModel.onStreamingConfirmationResult(streamingConfirmationResult) | ||
| // Clear result once consumed | ||
| navController.currentBackStackEntry?.savedStateHandle | ||
| ?.remove<StreamingConfirmationScreen.Result?>(StreamingConfirmationScreen.resultKey) | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't love the boilerplate this requires to get a result from the stream warning screen via the savedStateHandle. This seemed like the best solution though since I can't use a shared view model due to the fact that I need different behavior depending on whether the stream warning is showing from the now playing screen or the episode details screen (now playing plays the currently queued episode, epsidoe details queues and plays the currently viewed episode).
mchowning
commented
Apr 1, 2023
Comment on lines
+98
to
+101
| navController.previousBackStackEntry?.savedStateHandle?.set( | ||
| StreamingConfirmationScreen.resultKey, | ||
| result | ||
| ) |
There was a problem hiding this comment.
This is passing the result of what the user selected back to the previous screen.
ashiagr
approved these changes
Apr 3, 2023
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add settings screen for watch app and implements a setting to give a warning before streaming an episode.
Testing Instructions
Screenshots or Screencast
Checklist
modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...