Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up notification channels on watch #855

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Set up notification channels on watch #855

merged 1 commit into from
Mar 31, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Mar 30, 2023 •
edited
Loading

Description

This sets up the notification channels on the watch so that notifications will now work. Thanks to @ashiagr for suggesting this fix.

Testing Instructions

  1. Trigger a notification from the watch app. I did it by using adding these changes so that tapping on the Now Playing chip would trigger a notification.
  2. Observe that the notification is presented.

Screenshots or Screencast

Screen.Recording.2023-03-30.at.1.28.36.PM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning added the [Area] Wear OS watch app label Mar 30, 2023
@mchowning mchowning requested a review from a team as a code owner March 30, 2023 17:29
@mchowning mchowning mentioned this pull request Mar 30, 2023
Closed
56 tasks
ashiagr
ashiagr approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ashiagr ashiagr merged commit f9517b9 into add/wear Mar 31, 2023
@ashiagr ashiagr deleted the update/watch-notifications branch March 31, 2023 03:11
@ashiagr ashiagr mentioned this pull request Jul 22, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
[Area] Wear OS watch app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @ashiagr