Implement watch downloads screen #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, we were popping back to the screen before the episode screen.
56 tasks
ashiagr
approved these changes
Mar 31, 2023
| ) { | ||
|
|
||
| val viewModel = hiltViewModel<DownloadsScreenViewModel>() | ||
| val state by viewModel.stateFlow.collectAsState() |
There was a problem hiding this comment.
Now that collectAsStateWithLifecycle() is available with the recent lifecycle version bump, wdyt about replacing collectAsState() with it?
| ), | ||
| maxLines = 2, | ||
| ) | ||
| val shortDate = episode.publishedDate.toLocalizedFormatPattern("dd MMM") |
There was a problem hiding this comment.
Nitpick: I see that if the duration is less than an hour, mins are displayed slightly differently:
No need to fix it right now, just mentioning it as I noticed it in Figma.
There was a problem hiding this comment.
Thanks. I'll confirm with Adam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fills in the Downloads screen on the watch app.
In addition, this fixes an issue where after deleting a download, we would navigate back too far instead of just going back to the episode screen that initiated the deletion.
Testing Instructions
In addition to the following testing steps, the UI should also be in good shape as well.
Podcasts→ Select a podcast → Select an episode → tap on the Download "down arrow" icon).Screenshots or Screencast
Screen.Recording.2023-03-30.at.11.53.42.AM.mov
Checklist
modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...