Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable carousel autoscroll #850

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

mchowning
Copy link
Contributor

Description

Turning on autoscroll on the Discover carousel by removing the feature flag.

internal ref: p1680117820760509/1680117264.777019-slack-C02ATC80MUM

Warning
This PR is targeting the 7.35 release branch. Even though we're close to releasing that, I'm thinking we may want to go ahead and cut a new beta so if there is any issue we have a chance to catch it before release, but let me know what you think.

Testing Instructions

Review the auto scroll testing instructions from #818

Screenshots or Screencast

Screen.Recording.2023-03-29.at.3.37.18.PM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mchowning mchowning requested a review from a team as a code owner March 29, 2023 19:44
@ashiagr ashiagr merged commit 7dd6cba into release/7.35 Mar 30, 2023
@ashiagr ashiagr deleted the update/auto-scroll-carousel-enable branch March 30, 2023 04:02
@ashiagr
Copy link
Contributor

ashiagr commented Mar 30, 2023

I'm thinking we may want to go ahead and cut a new beta so if there is any issue we have a chance to catch it before release, but let me know what you think.

Sounds good. I included it in 7.35-rc-2 beta release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants