Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Automotive Up Next podcast images not loading #819

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix Automotive Up Next podcast images not loading #819

merged 2 commits into from
Mar 7, 2023

Conversation

geekygecko
Copy link
Member

Description

When opening the Up Next list in the Automotive app the podcast artwork wasn't loading, this change fixes that.

Fixes #813

Testing Instructions

  1. Load the mobile app into a mobile emulator
  2. Login or create an account
  3. Add multiple episodes to the Up Next
  4. Make sure the Up Next has synced to the server
  5. Load the Automotive app into an Automotive emulator
  6. Tap the settings cog
  7. Sign into the account
  8. Tap to open the full screen player
  9. Tap the Up Next list icon
  10. ✅ Verify the episode artwork is displayed.

Screenshots

Before After
Screenshot_20230307_234612 Screenshot_20230307_234716
Screenshot_20230307_234621 Screenshot_20230307_234724

@geekygecko geekygecko marked this pull request as ready for review March 7, 2023 13:27
@geekygecko geekygecko requested a review from a team as a code owner March 7, 2023 13:27
mchowning
mchowning approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! :shipit:

@mchowning mchowning merged commit 5595476 into main Mar 7, 2023
@mchowning mchowning deleted the update/automotive-up-next-artwork branch March 7, 2023 16:21
@ashiagr ashiagr added this to the 7.35 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.35
Development

Successfully merging this pull request may close these issues.

Automotive: Up Next podcast images aren't loading
3 participants
@geekygecko @mchowning @ashiagr