Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the Automotive account pages #798

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Improving the Automotive account pages #798

merged 2 commits into from
Feb 24, 2023

Conversation

geekygecko
Copy link
Member

Description

This change does the following:

  • Forces the Automotive app into car mode as some car companies don't set this and our car layout resources aren't picked up.
  • The font sizes for the hint text have increased on the account pages.
  • Improved the UI on the forgotten password page.
  • Made sure only the dark theme is used in the Automotive version.

Fixes #786

Testing Instructions

  • Deploy the automotive app to the Automotive emulator
  • Open Pocket Casts
  • Tap the settings cog
  • Tap "Set Up Account" option
  • Tap "Create account"
  • ✅ Verify the page looks better
  • Tap back and the "Sign in"
  • ✅ Verify the page looks better
  • Tap "I forgot my password"
  • ✅ Verify the page looks better

Screenshots

Before After
Screenshot_20230224_155050 Screenshot_20230224_155241
Screenshot_20230224_155058 Screenshot_20230224_155250

@geekygecko geekygecko marked this pull request as ready for review February 24, 2023 05:41
@geekygecko geekygecko requested a review from a team as a code owner February 24, 2023 05:41
mchowning
mchowning approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and the code looks good! 👍

automotive/src/main/java/au/com/shiftyjelly/pocketcasts/AutomotiveApplication.kt
@@ -82,6 +84,9 @@ class AutomotiveApplication : Application(), Configuration.Provider {
userEpisodeManager.monitorUploads(applicationContext)
downloadManager.beginMonitoringWorkManager(applicationContext)
userManager.beginMonitoringAccountManager(playbackManager)

// force the Automotive app into car mode as some car companies send the UI mode as normal, this makes sure the car resources such as layout-car are used.
this.getSystemService<UiModeManager>()?.enableCarMode(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever seen a function whose parameter only had a single valid value before. 😆

image

@mchowning mchowning merged commit 4fb9db7 into main Feb 24, 2023
@mchowning mchowning deleted the update/automotive-improvements branch February 24, 2023 16:12
@ashiagr ashiagr added this to the 7.34 ❄️ milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.34
Development

Successfully merging this pull request may close these issues.

Automotive: Improve sign in or create account pages
3 participants
@geekygecko @mchowning @ashiagr