Search history - Merge feature branch #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search history: Data layer
Added separator explicitly removing space after comma.
Search history: Display results
…-all-and-navigation Search history: Navigation and Clear All
Set up end of year modal bottom sheet when user is logged in only when eligible. Otherwise a blank compose modal sheet gets added that can take up focus and cause issues with talkback.
If podcastIds is empty, list should be empty after splitting by delimiter
This reverts commit 38f33b4
Max history count is added so that search history table doesn't grow too large
…m/Automattic/pocket-casts-android into task/752-search-history-fine-tune
…tune Search history: Design review
…y-analytics # Conflicts: # modules/services/analytics/src/main/java/au/com/shiftyjelly/pocketcasts/analytics/AnalyticsEvent.kt
…tics Search history - Analytics
# Conflicts: # CHANGELOG.md
mchowning
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Retested and everything is still working great! Wonderful work here @ashiagr !
One possible future improvement that came to my mind while I was testing... it might be nice if when you tap on a history item that item was moved to the top of the history list the next time you opened the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #752
Description
This merges "Search history" feature branch to
main.Testing Instructions
All PRs in #752 were reviewed and tested before merging into the feature branch. Smoke test the feature to see if everything's working after merging conflict resolutions.
Checklist
modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...