Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade exoplayer to 2.18.2 #707

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Upgrade exoplayer to 2.18.2 #707

merged 4 commits into from
Jan 18, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jan 17, 2023

This change upgrades ExoPlayer from 2.16.1 to 2.18.2, originally attempted in #175

Steps to Test

Test Playback Effects

Test Chapters

  • Open the "Upgrade" podcast https://pca.st/upgrade
  • Play an episode
  • Open the full-screen player by tapping on the mini player
  • Check the chapters tab is shown and contains chapters.

@ashiagr ashiagr marked this pull request as ready for review January 17, 2023 08:22
@ashiagr ashiagr requested a review from a team as a code owner January 17, 2023 08:22
mchowning
mchowning approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Everything is working well for me.

@mchowning mchowning enabled auto-merge January 18, 2023 17:24
@mchowning mchowning merged commit 7f44dab into main Jan 18, 2023
@mchowning mchowning deleted the task/update_exoplaye_2_18_2 branch January 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashiagr @mchowning @geekygecko