Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 2022 EoY #672

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Disable 2022 EoY #672

merged 3 commits into from
Jan 4, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jan 4, 2023

Description

This PR disables 2022 EoY feature.

Warning
Targets 7.29

Testing Instructions

  1. Launch the app.
  2. Login with an account with some listening history (>5mins).
  3. Go to the Profile screen.
  4. Notice that EoY profile screen card is not displayed.
  5. Relaunch the app.
  6. Notice that EoY launch modal is not shown.

ashiagr added 2 commits January 4, 2023 17:55
@ashiagr
Disable EoY
496a919
@ashiagr
Remove END_OF_YEAR_REQUIRE_LOGIN flag
9978364 
Since login is mandatory for EoY, this feature flag is not required anymore.
@ashiagr ashiagr added this to the 7.29 ❄️ milestone Jan 4, 2023
@ashiagr ashiagr requested a review from a team as a code owner January 4, 2023 12:38
mchowning
mchowning approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works well.

I did push a changelog entry to this branch. Just let me know if you see any issues with that.

@ashiagr
Copy link
Contributor Author

ashiagr commented Jan 4, 2023

I did push a changelog entry to this branch. Just let me know if you see any issues with that.

LGTM 👍

@mchowning mchowning merged commit 4addb22 into release/7.29 Jan 4, 2023
@mchowning mchowning deleted the update/disable-eoy branch January 4, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.29
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiagr @mchowning