Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autolink for podcast descriptions #657

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

TylerCarberry
Copy link
Contributor

@TylerCarberry TylerCarberry commented Dec 15, 2022

Description

Enable autolink on podcast descriptions to allow you to click on urls. This should also support email addresses, but I haven't found any podcasts to test that on.

Testing Instructions

  1. Open a podcast with a link in their description. Up First and Waveform have them.
  2. Ensure you can tap on them to open the browser
  3. Ensure the color of these links matches the tintColor of the podcast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md

Before & After

Before After

@TylerCarberry TylerCarberry requested a review from a team as a code owner December 15, 2022 02:35
@TylerCarberry TylerCarberry force-pushed the tyler/autolink_description branch from 929c43d to 8a0d213 Compare December 15, 2022 02:43
@CookieyedCodes
Copy link

Nice instead of the typical blue could we get links to match the theam not, you might have allready done this tho 🤔 😉

@TylerCarberry
Copy link
Contributor Author

Yep! Already fixed, I just didn't update the screenshot

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome additon! Thank you so much 🙌

Updated screenshots:

Before Now

@ashiagr ashiagr merged commit 27cf261 into Automattic:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants