-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media notification controls configuration to support 3 icons #641
Fix media notification controls configuration to support 3 icons #641
Conversation
4f08a73
to
edf7c9d
Compare
Hey @ashiagr,This is working fine with android auto emulator right now, but I encountered a weird bug while testing on android auto emulator where, there were random icons shown instead of the media action, even for the forward and backward icons. even tough the functionality of the action were working as intended just the icons were different. Couldn't reproduce it now, otherwise would attached a screen capture of that. |
👋 @ksog66! Thank you so much for working on this!
I can't find any existing issue for it. And haven't been able to reproduce it so far. I'll let you know if I can reproduce it. |
edf7c9d
to
f3de9f7
Compare
Look like wrong icons could be a DHU emulator thing and here's how you can get them right: I'm still not able to reproduce wrong icons. |
Yes, i think it's an DHU emulator issue as I also encountered it when tested my changes for the first time on DHU emulator. After that even i am not able to reproduce the issue. |
Awesome work, @ksog66! 🥇 I only have minor comments:
If you can address them now, I can prioritize and include this fix in 7.28. |
f3de9f7
to
2867fec
Compare
Made the changes. Please review it. also have updated the changelog and put in 7.8 |
2867fec
to
65a07db
Compare
Fix media notification controls configuration to support 3 icons
Description
Add support for media notification controls configuration to support Maximum 3 icons.
Fixes #590
Testing Instructions
Screenshots or Screencast
Checklist
modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...