End of Year: Fix occasional crash on returning from share #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiagr
pushed a commit
that referenced
this pull request
Nov 23, 2022
…tion End of Year: Fix occasional crash on returning from share
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an occasional crash when at the time of sharing, the activity from where stories are launched, is moved to the background and killed due to low memory. On returning from share, the activity is recreated and stories are reloaded, but restarting the paused timer, and trying to update the current story when stories are still loading, crashes the app.
The fix ensures that the timer to switch to the next story doesn't start when stories are still loading. Once stories are loaded, the timer starts again.
Testing Instructions