End of Year: Enable feature #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Retested the flow, and it looks good. Great work on this!
Only question I have is whether we would be better off just removing the feature flag entirely. It's unlikely we're ever going to need it again, and It would be easy enough to add back in if we did need to turn this off for some reason.
|
Feature flag removed, also added changelog entry. Thank you for the final review! 🎉 |
ashiagr
force-pushed
the
task/410-enable-eoy
branch
from
11a91ac to
1e1a9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables EoY feature.