Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Top categories story design #579

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 15, 2022

📘 Project: #410

iOS PR: Automattic/pocket-casts-ios#468

Description

Adds the design for the top categories story.

Testing Instructions

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. Navigate to the 4th story
  5. ✅ Check the design

Screenshots or Screencast

Pixel 5 Nexus 7 (2012)

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner November 15, 2022 06:55
@ashiagr ashiagr mentioned this pull request Nov 15, 2022
35 tasks
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much fancy matrix work here! 😄 Nice job! I think there are still some small issues with the font size and the durations. Slightly more concerning is that I saw the "Technology" word wrapping even without any font scaling. Might be good to see if there's a way we can make allow that text to be wider, but I realize that's probably a really tricky problem to solve since we don't know how wide the text will be.

Base automatically changed from task/410-share-text to main November 16, 2022 13:06
Also increased width slightly for texts
@ashiagr ashiagr enabled auto-merge November 16, 2022 13:17
@ashiagr ashiagr merged commit 6c6321d into main Nov 16, 2022
@ashiagr ashiagr deleted the task/410-top-categories-design branch November 16, 2022 13:36
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants