Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for effects bottomsheet flickering to the expanded state while being dragged #575

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

VGJohn
Copy link
Contributor

@VGJohn VGJohn commented Nov 15, 2022

Description

Effects bottom sheet flickers to the expanded state as the user drags the bottom sheet. The ensureExpanded() function is called when the player state changes which can cause the bottom sheet to expand while being dragged. Updated the BaseDialogFragment to monitor the dragged state of the bottom sheet and skip setting the expanded state if the user is actively dragging the bottom sheet.

Fixes #571

Testing Instructions

  1. Play any podcast episode
  2. Tap on playback effects to open the bottom sheet
  3. Drag the bottom sheet down as seen in the issue

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@VGJohn VGJohn requested a review from a team as a code owner November 15, 2022 00:12
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thank you, @VGJohn.

@ashiagr ashiagr added this to the 7.28 milestone Nov 30, 2022
@ashiagr ashiagr merged commit 3f13291 into Automattic:main Nov 30, 2022
@VGJohn VGJohn deleted the effects-bottomsheet-flickering branch November 30, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback effects bottom sheet hide animation buggy when swiping down on it
2 participants