Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Number of listened podcasts/episodes story design #565

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 12, 2022

📘 Project: #410

iOS PR: Automattic/pocket-casts-ios#454

Description

Add the design for the "number of podcasts/episodes listened" story.

The podcasts cover displayed is determined by getting the top 10 podcasts and reversing it. We then display the last 6 available.

Testing Instructions

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. Navigate to the 5th story
  5. ✅ Check the design

Screenshots or Screencast

Phone (Pixel 6) Tablet (Nexus 7 - 2012)

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner November 12, 2022 06:21
@ashiagr ashiagr mentioned this pull request Nov 12, 2022
35 tasks
Base automatically changed from task/410-top-podcast-design to main November 12, 2022 07:30
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked really well! Amazing work.

My only comment would be that the text might look better with the same line breaks as the design, rather than just letting the width do it.

Screenshot 2022-11-14 at 11 43 25 am

@ashiagr
Copy link
Contributor Author

ashiagr commented Nov 14, 2022

I added the line break feedback to the backlog. As discussed, I'll take it up later.

@ashiagr ashiagr merged commit 2e7cce0 into main Nov 14, 2022
@ashiagr ashiagr deleted the task/410-listened-to-podcasts branch November 14, 2022 03:52
@mchowning
Copy link
Contributor

mchowning commented Nov 14, 2022

My only comment would be that the text might look better with the same line breaks as the design, rather than just letting the width do it.

I wonder how line breaks will look in other languages though. 🤔 I always try to avoid line breaks for that reason, but maybe they don't cause problems in reality.

@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants