End of Year: Listening time story design #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiagr
force-pushed
the
task/410-listening-time-story-design
branch
from
4109f1a to
e8c1c1b
Compare
geekygecko
approved these changes
Nov 10, 2022
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .padding(top = 24.dp, start = 40.dp, end = 40.dp) | ||
| ) |
There was a problem hiding this comment.
Can we give this 80% opacity to match the design, also should we make it slightly bolder.
There was a problem hiding this comment.
Nice observation! Updated in 1137927.
| } | ||
| .graphicsLayer( | ||
| translationX = -translateBy.toFloat() | ||
| ) |
There was a problem hiding this comment.
Amazing work getting this working and multiple artworks lined up. 🏆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the design for the "listening time" story.
Testing Instructions
END_OF_YEAR_ENABLEDfeature flag totruein base.gradleScreenshots or Screencast
Checklist
modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...