Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Of Year: Intro story design #553

Merged
merged 10 commits into from
Nov 10, 2022
Merged

End Of Year: Intro story design #553

merged 10 commits into from
Nov 10, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 8, 2022

📘 Project: #410

iOS PR: Automattic/pocket-casts-ios#448

Description

This PR

  • Adds the final design for the Intro story. 8dfa151
  • Tweaks how stories are presented on a tablet (or a large screen device). 0747890, e5aa429
  • Adjusts snapshot to allow creating a bitmap for a view outside the visible area and allows scrolling the screen, keeping existing behavior to switch to other stories. 617555c, 3c829f7

Testing Instructions

Intro Story

The tests here are mainly visual. To provide a somewhat uniform experience some of the items of the story are calculated in weights, so they can appear more or less with the same size on different screens.

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. ✅ Check the design of the first story

Tablet

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. ✅ Notice that stories don't appear full screen, instead they're presented in the center of the screen

Screenshots or Screencast

Phone
Tablet (Nexus 9)

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

# Conflicts:
#	app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt
This will allow customizing dialog height for tablets
Since now bitmap can be drawn outside visible area, stories are made scrollable.

Also, it is now not necessary to mark a story as interactive. We just need to ensure that we don't add interactive elements in a story view if we want it to be non interactive.
@ashiagr ashiagr requested a review from a team as a code owner November 8, 2022 13:29
@ashiagr ashiagr mentioned this pull request Nov 8, 2022
35 tasks
@ashiagr ashiagr changed the base branch from main to task/410-modal-profile-card-design November 9, 2022 01:23
Base automatically changed from task/410-modal-profile-card-design to main November 10, 2022 03:45
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks awesome. I wonder if the image and message should come down a little but I don't mind if you want to leave them there.

Notification_Center

@ashiagr
Copy link
Contributor Author

ashiagr commented Nov 10, 2022

I wonder if the image and message should come down a little but I don't mind if you want to leave them there.

It looked cluttered on a smaller device if I do that, but I'll reconsider it in a future PR.

@ashiagr ashiagr merged commit 3ecfe73 into main Nov 10, 2022
@ashiagr ashiagr deleted the task/410-intro-story-design branch November 10, 2022 05:15
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants