-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End Of Year: Intro story design #553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt
This will allow customizing dialog height for tablets
Since now bitmap can be drawn outside visible area, stories are made scrollable. Also, it is now not necessary to mark a story as interactive. We just need to ensure that we don't add interactive elements in a story view if we want it to be non interactive.
ashiagr
changed the base branch from
main
to
task/410-modal-profile-card-design
November 9, 2022 01:23
geekygecko
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Philip Simpson <[email protected]>
It looked cluttered on a smaller device if I do that, but I'll reconsider it in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS PR: Automattic/pocket-casts-ios#448
Description
This PR
Testing Instructions
Intro Story
The tests here are mainly visual. To provide a somewhat uniform experience some of the items of the story are calculated in weights, so they can appear more or less with the same size on different screens.
END_OF_YEAR_ENABLED
feature flag totrue
in base.gradleTablet
END_OF_YEAR_ENABLED
feature flag totrue
in base.gradleScreenshots or Screencast
Checklist
modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...