Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for auto subscribe enabled in main app #545

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

VGJohn
Copy link
Contributor

@VGJohn VGJohn commented Nov 5, 2022

Description

Auto subscribe is enabled in the main app since the default return value from the settings preferences is set to true instead of false. From some comments I've seen, auto subscribe is only meant to be enabled in the automotive app.

Fixes #544

Testing Instructions

  1. Open the discover tab and click on any random podcast you aren't subscribed to
  2. Play an episode
  3. Go back to the podcasts list, and you will notice you are now subscribed to the podcast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@VGJohn VGJohn requested a review from a team as a code owner November 5, 2022 03:27
@ashiagr
Copy link
Contributor

ashiagr commented Nov 5, 2022

I can confirm this fixes the issue, thank you so much @VGJohn! 🙏
I'll cherry-pick it into a new beta build in a separate PR.

@ashiagr ashiagr added this to the 7.26 ❄️ milestone Nov 5, 2022
@ashiagr ashiagr merged commit 8c15f21 into Automattic:main Nov 5, 2022
@VGJohn VGJohn deleted the auto-subscribe-fix branch November 5, 2022 05:11
ashiagr added a commit that referenced this pull request Nov 5, 2022
Fix for auto subscribe enabled in main app
ashiagr added a commit that referenced this pull request Nov 5, 2022
Fix for auto subscribe enabled in main app
@ashiagr
Copy link
Contributor

ashiagr commented Nov 5, 2022

This is included in a new beta 7.26-rc-4.

@CookieyedCodes
Copy link

In my opinion it wouldn't be a bad toggle in settings to enable this 🤔, obviously off by default though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podcasts are automatically being subscribed to when an episode is listened to
3 participants