Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Show first and last story #542

Merged
merged 5 commits into from
Nov 9, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 4, 2022

📘 Project: #410

iOS PR: Automattic/pocket-casts-ios#420

Description

Adds the first and last story. The last story also adds a replay option.

Testing Instructions

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app and make sure you're logged in to an account with a few items on Listening History
  3. When the prompt appears, tap "View My 2022"
  4. ✅ Check that the first story contains a "Let's celebrate..." string
  5. Tap on the right side to go to the next story
  6. ✅ Check that it works
  7. Advance to the last story
  8. ✅ Wait for it to end, notice that the stories won't start over
  9. Tap the "Replay" button
  10. ✅ Check that the stories start again

Screenshots or Screencast

Intro story Epilogue story

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner November 4, 2022 06:56
@ashiagr ashiagr mentioned this pull request Nov 4, 2022
35 tasks
Base automatically changed from task/410-show-longest-episode to main November 9, 2022 10:04
@MiSikora MiSikora self-assigned this Nov 9, 2022
@geekygecko geekygecko self-requested a review November 9, 2022 10:17
@geekygecko geekygecko removed their request for review November 9, 2022 10:20
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has already been reviewed by @MiSikora so just approving it so it can be merged.

@ashiagr ashiagr merged commit 08d75f0 into main Nov 9, 2022
@ashiagr ashiagr deleted the task/410-show-first-and-last-story branch November 9, 2022 11:19
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants