-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: Show top 1 podcast and top 5 podcasts #537
Conversation
…410-show-top-podcasts # Conflicts: # modules/features/endofyear/src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/stories/EndOfYearStoriesDataSource.kt
988a81e
to
376104a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
While testing this I did notice that there is a bit of a flicker when switching to the stories with 5 list items (happen on both the top podcast and top categories ones). It's quick (you really have to slow down the video to see it), but it is definitely noticeable on my device.
device-2022-11-03-095115.mp4
My guess is that coil is loading the podcast images asynchronously. If it's not easy to delay displaying the screen until the images are loading, perhaps we could just include some kind of placeholder so the text doesn't jump (ideally, the PodcastImage
component itself would take care of that, or at least have an option to to take care of that). That would probably be enough to completely hide this. I haven't tested any of that, so all of that might be completely wrong.
I'll go ahead and approve because this doesn't need to be addressed in this PR.
...main/java/au/com/shiftyjelly/pocketcasts/endofyear/views/stories/StoryTopFivePodcastsView.kt
Outdated
Show resolved
Hide resolved
Thanks for reviewing it, @mchowning! I'll address the flicker issue in a future PR. |
iOS PR: Automattic/pocket-casts-ios#415
Description
Adds the story for the top 1 podcast and the top 5 podcasts.
PS: Ignore hard-coded strings and placeholder layouts/ design in StoryViews.
To test
Testing Instructions
END_OF_YEAR_ENABLED
feature flag totrue
inbase.gradle
Screenshots or Screencast
Checklist
N/A (added placeholder layouts + strings)
modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...