End of Year: Show total listening time for the year #522
Conversation
ashiagr
changed the title
There was a problem hiding this comment.
Looks good. Nice work @ashiagr !
FWIW, I did see the Stories cycling faster than expected a few more times while testing this (not sure why, but I found this was much easier to reproduce today compared to yesterday). The speedup generally seemed to be 2x-4x as fast.
device-2022-11-01-101558.mp4
One interesting thing I noticed is that when the speedup occurs, clicking the Share button does not stop the Stories from continuing to progress. The right Story is still shared, but in the background I can see the UI continuing to move through the stories. This does not seem to occur for me when the Stories are playing at the correct speeds though (i.e., the Stories immediately stop progressing when I tap Share). I wonder if this might give a hint as to the underlying cause. 🤔
| Without speedup | With speedup |
|---|---|
device-2022-11-01-102833.mp4 |
device-2022-11-01-102810.mp4 |
This isn't anything that needs to be addressed in this PR.
| @@ -1389,6 +1389,7 @@ | |||
| <string name="end_of_year_prompt_card_title" translatable="false">@string/end_of_year_launch_modal_title</string> | |||
| <string name="end_of_year_prompt_card_summary">See your top podcasts, categories, listening stats and more.</string> | |||
| <string name="end_of_year_share_via" translatable="false">@string/podcasts_share_via</string> | |||
| <string name="end_of_year_listening_time">In 2022, you spent %1$s listening to podcasts.</string> | |||
There was a problem hiding this comment.
Nitpick: I don't think we're actually telling them how much time they spent listening to podcasts because we're not taking account of skipping forward/backward or playback speed. I think we're more telling them that they listened to XXX hours/minutes of podcasts.
For example, I can make the total time go down if I rewind a podcast or make a previously played podcast as unplayed.
Just raising this as something worth keeping in mind. Definitely not a blocker.
There was a problem hiding this comment.
I understand your point, @mchowning. AFAIU, it is just an approximate listening time, does not take into account changes to played time due to skipping, and matches iOS behavior.
I'll keep it in mind for sure. 👍
Thanks for sharing the video and observations! I wasn't able to check that issue yet but they'll definitely be handy when I'll come to it. 🙇♀️ |
iOS PR: Automattic/pocket-casts-ios#411
Description
Show approximate total listening time in 2022. (Design not covered)
Testing Instructions
END_OF_YEAR_ENABLEDfeature flag totrueinbase.gradleScreenshots or Screencast
Checklist
N/A
modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...