Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL notes in the webview #514

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Conversation

VGJohn
Copy link
Contributor

@VGJohn VGJohn commented Oct 30, 2022

Description

Added RTL support to the notes that display in the webview of the EpisodeFragment and NotesFragment. dir="rtl" needs to set on the notes html for it to display correctly so check if the device locale is RTL and adding the appropriate tag to the html body.

Fixes #109

Testing Instructions

  1. Set the device language to RTL language
  2. Open podcast episode
  3. See that the notes in the webview are aligned RTL

Screenshots or Screencast

Screenshot_20221030_050715
Screenshot_20221030_050638

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@VGJohn VGJohn requested a review from a team as a code owner October 30, 2022 05:10
@VGJohn VGJohn changed the title Support RTL notes in the webview, needs to be enabled in the html itself Support RTL notes in the webview Oct 30, 2022
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!
Thank you @VGJohn, @TylerCarberry

@ashiagr ashiagr added this to the 7.27 milestone Nov 2, 2022
@ashiagr ashiagr merged commit 3ab70e7 into Automattic:main Nov 2, 2022
@VGJohn VGJohn deleted the notes-rtl branch November 5, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect text alignment in episode description and notes for RTL languages
3 participants