-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: Story snapshot and share #505
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c3cb68e
Refactor: fix package
ashiagr a6779bd
Add file utility to save bitmap to file
ashiagr fd42689
Save story and show share view
ashiagr 1e7e6b3
Fix existing tests
ashiagr 5f6c05b
Pause/ play story when sharing is shown / dismissed
ashiagr 94276c7
Attempt to fix weird duplicate stories state
ashiagr 052069b
Introduce isInteractive story
ashiagr 90e0a7c
Update fake story layout
ashiagr 295eae7
Update translatable false
ashiagr b42faa6
Update modules/services/utils/src/main/java/au/com/shiftyjelly/pocket…
ashiagr cd3609e
Scope onCaptureBitmap to inside StoriesView
ashiagr 4b73333
Move requireNotNull check up the hierarchy to fail faster
ashiagr 22b0d71
Rename snapShot, inline callback and add notes
ashiagr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This launches share intent with an edit button. On clicking "edit" from the chooser, an exception is seen in logcat:
I tried to grant
FLAG_GRANT_WRITE_URI_PERMISSION
locally but it didn't help. Strangely, testing on an emulator shows logs even for reading the file. Also see related SO discussions link 1, link2.Sharing and editing work without problems. I still have to see why these logs are shown. Let me know if you have any suggestions. Another option is to not show the edit button, the share dialog will look this way then: