Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Show profile card and badge #498

Merged
merged 7 commits into from
Oct 27, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Oct 26, 2022

📘 Project: #410

iOS PR: Automattic/pocket-casts-ios#393

Description

Adds a badge and the End of Year card structure to the Profile screen.

Design is not on the scope of this task.

Testing Instructions

Badge

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app
  3. ✅ Check that there's a badge on the Profile icon at the tab bar
  4. Tap Profile
  5. ✅ Check that the badge disappears
  6. Re-run the app
  7. ✅ Check that the badge doesn't appear anymore

Card

  1. Set END_OF_YEAR_ENABLED feature flag to true in base.gradle
  2. Run the app
  3. Dismiss the EoY launch modal
  4. Go to Profile tab
  5. ✅ Check that there's a card at the top of Stats about the End of Year
  6. Tap it
  7. ✅ Check that the stories screen is shown
  8. Dismiss the stories screen
  9. Rotate the device
  10. ✅ Check that there's a card at the top of Stats about the End of Year (<- there are separate portrait and landscape layouts for the profile tab, so make sure that the card is visible for both the modes.)

Screenshots or Screencast

Badge Card
badge card

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Set story length on mock story
@ashiagr ashiagr force-pushed the task/410-profile-card-and-badge branch from d2481d3 to c9a27cb Compare October 27, 2022 06:14
Base automatically changed from task/410-create-dummy-stories to main October 27, 2022 07:44
@ashiagr ashiagr merged commit 1df40d5 into main Oct 27, 2022
@ashiagr ashiagr deleted the task/410-profile-card-and-badge branch October 27, 2022 07:44
@ashiagr ashiagr added this to the 7.27 ❄️ milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants