Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the long press option in the fullscreen player #483

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

VGJohn
Copy link
Contributor

@VGJohn VGJohn commented Oct 25, 2022

Redesign the long press option in the fullscreen player to match the rest of the bottom sheet design

Continuation of this work #451, think all the bottom sheets in the player have the same design now 😄

Fixes #31

Checklist

  • Should this change be included in the release notes? If yes, please add a line in CHANGELOG.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack?
  • Have you tested in different themes?
  • Does the change work with a large display font?
  • Are all the strings localized?
  • Could you have written any new tests?
  • Did you include Compose previews with any components?
longpressredesign.mp4

@VGJohn VGJohn requested a review from a team as a code owner October 25, 2022 04:31
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @VGJohn for making all player bottom sheets consistent. They look so much better!

@ashiagr ashiagr merged commit 2402df8 into Automattic:main Oct 26, 2022
@VGJohn VGJohn deleted the long-press-redesign branch October 26, 2022 11:15
@ashiagr ashiagr added this to the 7.26 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal from long-pressing skip forward or backward does not reflect theme
2 participants