Use same date format for next episode and previous #477
Conversation
| @@ -43,7 +43,7 @@ class RelativeDateFormatter(val context: Context) { | |||
| } | |||
| } else if (Locale.getDefault().language == "en") { | |||
| // if using an old Android version but using English then add Today and Yesterday | |||
| val alternativeString = formatCloseDaysOld(calendar, resources) | |||
| val alternativeString = formatCloseDaysOld(calendar, context.resources) | |||
There was a problem hiding this comment.
I also removed this resources param since there's already a field for context
There was a problem hiding this comment.
Thanks for looking making the next episode much nicer to read and cleaning up the context code. I think there is an issue with our RelativeDateFormatter not supporting future dates as November 6 isn't this Sunday but the next. Did you want to take a look at this? If not I'm happy to.
|
Fixed! Just double check this is the format you want to show. I think it should be clear from the context whether "sunday" means last sunday (episode release date) or next sunday (prediction date) |
There was a problem hiding this comment.
Thank you so much for the changes, @TylerCarberry 🙏 and really sorry for taking so long to review.
I just left a couple of super minor suggestions. Other than that, date formatting looks much better now! 🎉
Also, it'll be awesome to add a CHANGELOG entry to 7.28 for the fix.
And you can run the following command to autocorrect spotless formatting issue:
./gradlew :spotlessApply
modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/entity/Podcast.kt
Show resolved
Hide resolved
...on/src/main/java/au/com/shiftyjelly/pocketcasts/localization/helper/RelativeDateFormatter.kt
Outdated
Show resolved
Hide resolved
Description
Use the same date format for the predicted episode date and the dates in the list. I'm in the US, I think that's why the dates are in the different order
Before & After
