Fix issue with full screen video player not closing on the first time #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on the first time, when clicking 'close' button move videoPlayerShown in openFullscreenViewPlayer, because openFullscreenViewPlayer was called in setupPlayerViews, but we didn't change videoPlayerShown value here
…on the first time in landscape mode"
mchowning
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Video player in the full screen module (landscape) was not closing on the first time we clicked on 'X' button, because MainActivity didn't update videoPlayerShown value when we clicked play/pause button
moved videoPlayerShown updating logic in the openFullscreenViewPlayer, because its called in 2 places and it's better to have one place to assing value, rather than in 2 places
Fixes #463
Checklist