Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial value for skip backwards setting uses the skip forwards value #425

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Initial value for skip backwards setting uses the skip forwards value #425

merged 2 commits into from
Oct 20, 2022

Conversation

VGJohn
Copy link
Contributor

@VGJohn VGJohn commented Oct 20, 2022

Just spotted this minor issue, looks like a bad copy paste maybe 😄

The initial value for the skip backwards setting was using the skip forwards value instead of the skip backwards value.

@VGJohn VGJohn requested a review from a team as a code owner October 20, 2022 09:43
ashiagr
ashiagr approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for spotting it, @VGJohn! 🥇
Your small changes are really impactful! 🙌

@ashiagr
Copy link
Contributor

ashiagr commented Oct 20, 2022

👋@VGJohn, can you add a changelog entry something like: Fixed skip backwards settings?

I'll merge the PR once this is done.

@VGJohn
Copy link
Contributor Author

VGJohn commented Oct 20, 2022

Done 😃

@ashiagr ashiagr enabled auto-merge October 20, 2022 14:53
@ashiagr ashiagr merged commit 89a7238 into Automattic:main Oct 20, 2022
@VGJohn VGJohn deleted the skip-backward-initial-setting branch October 20, 2022 16:07
ashiagr added a commit that referenced this pull request Oct 21, 2022
@ashiagr
Merge pull request #425 from VGJohn/skip-backward-initial-setting
ebb3109 
Initial value for skip backwards setting uses the skip forwards value
@ashiagr ashiagr mentioned this pull request Oct 21, 2022
Merged
@VGJohn VGJohn mentioned this pull request Oct 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VGJohn @ashiagr