-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: Add modal structure #413
Conversation
import kotlinx.coroutines.CoroutineScope | ||
import kotlinx.coroutines.launch | ||
|
||
@OptIn(ExperimentalMaterialApi::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used ModalBottomSheetLayout which is experimental right now and I had to opt-in for ExperimentalMaterialApi
. It made things really simple, I also tested it works on older Android versions (API level 23). But let me know if it's a deal breaker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine. With compose still relatively young I don't think we should be too hesitant about using experimental apis when they make sense because a lot of fairly fundamental stuff still seems to be experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm excited that you're starting in on the EOY project. 😄
This PR adds a
Compose
modal bottom sheet that prompts the user to check their End of Year. Design (and tablet) is not covered in this task and will be done in a future PR.To test
END_OF_YEAR_ENABLED
feature flag totrue
in base.gradleChecklist