Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off Sentry's file IO tracing #395

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

mchowning
Copy link
Contributor

Description

This fixes a problem where the in-app log files were not getting updated correctly. Instead of appending to the log file it seems that the last line of the log file was just getting replaced.

It seems this started occurring because Sentry does byte-code manipulation to some of the File I/O classes. I'm not clear on exactly what they're doing that is causing this problem, but turning that off seems to get our logs working again.

Note
I believe we should include this as a beta-fix since it basically makes the app logs that get sent with support requests useless. For that reason, I'm targeting the release/7.24 branch. Let me know if you disagree.

Fixes #394

To Test

  1. Open the app
  2. Do some things that would generate logs
  3. Take a look at the log file on the phone (data/data/au.com.shiftyjelly.pocketcasts.debug/files/logs/)
  4. Observe that the logs are being updated appropriately since this fix has been applied (there may be missing logs from before you applied this fix).

Checklist

  • Should this change be included in the release notes? If yes, please add a line in CHANGELOG.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack?
  • Have you tested in different themes?
  • Does the change work with a large display font?
  • Are all the strings localized?
  • Could you have written any new tests?
  • Did you include Compose previews with any components?

@mchowning mchowning requested a review from a team as a code owner October 11, 2022 20:28
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested an earlier version where I could reproduce the issue.

I can confirm that these changes fix the issue. Thanks for taking care of it @mchowning!

@ashiagr ashiagr merged commit 82a380e into release/7.24 Oct 12, 2022
@ashiagr ashiagr deleted the fix/sentry-file-io-breakage branch October 12, 2022 06:51
@mchowning mchowning mentioned this pull request Oct 12, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants