Target Android 13 #312
Merged
Target Android 13 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
commented
Sep 13, 2022
| @@ -24,6 +24,8 @@ | |||
| <uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" /> | |||
| <uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" /> | |||
|
|
|||
| <uses-permission android:name="com.google.android.gms.permission.AD_ID" tools:node="remove"/> | |||
There was a problem hiding this comment.
I checked a release apk and it did contain the AD_ID permissions, so added this to remove it based on @geekygecko 's comment in this issue.
mchowning
force-pushed
the
update/target-android-13
branch
from
e4b317f to
83ce47e
Compare
# Conflicts: # CHANGELOG.md # modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/playback/PlaybackService.kt
Handled getApplicationInfo deprecated warning to get Sentry dsn
|
I smoke-tested the app for Android 13 behavior changes. One thing I noticed is that there were changes to user experience for media controls on Android 13. We now display two additional actions: playback speed and mark played:
While playback speed looks like a nice-to-have action, I'm not sure about the mark played action and if we want to replace it with another useful action. In any case, I found no issues with the actions and the PR can be merged in its current state. I also resolved a merge conflict in cfa82f2. |
ashiagr
approved these changes
Sep 20, 2022
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating our compile and target sdks to Android 13 (API 33).
I initially tried to go through and switch all of the
onBackPressedusages to use theonBackPressedDispatcher, but this proved rather tricky and I was worried about creating regressions, so I just left the methods as-is and suppressed the deprecation warnings. I figured that we could work on removing the deprecated methods later (created an issue to keep track of this).Because this kind of change is rather risky, I'm thinking we should hold off on merging it until after 7.23 enters code freeze on Monday. That way we'll give this as much soak time as possible before it gets to our users.
To Test
I did a fair bit of testing on this, but this is bumping our targetSdk up two versions, so some more careful testing is definitely called for here.
Checklist