Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom video not opening in full-screen mode #304

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Sep 12, 2022

Fixes #64

Description

This PR opens the full-screen player when a custom file (or a UserEpisode) of video type is played. Previously, the player retained the mini mode.

It does that by finding the Playable instance (which looks for a UserEpisode when a normal Episode is not found) before checking if it is a video file.

To Test

  1. Launch the app and go to Profile -> Files.
  2. Add a custom MP4 video file.
  3. Play the custom MP4 file.
  4. ✅ Notice that the player comes in full-mode.
device-2022-09-12-131745.mp4

Checklist

  • Should this change be included in the release notes? If yes, please add a line in CHANGELOG.md
  • Have you tested in landscape?
  • Have you tested accessibility with TalkBack? N/A
  • Have you tested in different themes? N/A
  • Does the change work with a large display font? N/A
  • Are all the strings localized? N/A
  • Could you have written any new tests? N/A
  • Did you include Compose previews with any components? N/A

@ashiagr ashiagr added this to the 7.23 milestone Sep 12, 2022
@ashiagr ashiagr requested a review from a team as a code owner September 12, 2022 07:57
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @ashiagr ! :shipit:

@mchowning mchowning merged commit 4a8c57f into main Sep 12, 2022
@mchowning mchowning deleted the issue/64-show-full-screen-player-video-user-episode branch September 12, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When playing an uploaded video file, the fullscreen player does not open
2 participants