Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long podcast website links overflowing #232

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

geekygecko
Copy link
Member

The podcast website link was overflowing if it was too long. The fix for this was to anchor the end of the view to the edge of the screen.

Fixes #230

Test Steps

  1. Change Podcast.getShortUrl() to return a long website such as "areallylongwebaddressthatwontfitonthescreencanifixityesican.com.au"
  2. Tap the Podcasts tab
  3. Tap on a podcast
  4. Tap the expand arrow icon

The podcast website link shouldn't overflow the edge of the page.

@geekygecko geekygecko requested a review from a team as a code owner August 10, 2022 11:18
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Found it as described in my testing.

@ashiagr ashiagr enabled auto-merge August 10, 2022 11:36
@ashiagr ashiagr merged commit bcb07ca into main Aug 10, 2022
@ashiagr ashiagr deleted the fix/long-podcast-website branch August 10, 2022 11:52
@ashiagr ashiagr added this to the 7.21 ❄️ milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long Podcast Links extend out of the page
2 participants