Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dark theme background color #215

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix dark theme background color #215

merged 1 commit into from
Aug 8, 2022

Conversation

geekygecko
Copy link
Member

The dark theme background color was changed to match iOS but this was a mistake as iOS uses it differently.

Android Before iOS Android After
Screenshot_20220808_212652 Simulator Screen Shot - iPhone 12 - 2022-08-08 at 21 26 12 Screenshot_20220808_214401

Fixes #206

@geekygecko geekygecko marked this pull request as ready for review August 8, 2022 12:16
@geekygecko geekygecko requested a review from a team as a code owner August 8, 2022 12:16
mchowning
mchowning approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@mchowning mchowning merged commit 36a2d2c into main Aug 8, 2022
@mchowning mchowning deleted the update/background-color branch August 8, 2022 20:26
@geekygecko geekygecko mentioned this pull request Aug 19, 2022
Closed
@ashiagr ashiagr added this to the 7.21 ❄️ milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.21
Development

Successfully merging this pull request may close these issues.

Dark Mode colors are slightly different on 7.20
3 participants
@geekygecko @mchowning @ashiagr