Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert SafeDate change because it does not avoid crash #1583

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Dec 1, 2023

Description

This reverts #1573 because that did not end up avoiding the crash. Since it adds a bit of code complexity without bringing any benefit, it's best to remove it.

Testing Instructions

Just smoke-test the app a bit, and make sure you try "The Daily" and "Stuff You Should Know" podcasts.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning marked this pull request as ready for review December 1, 2023 13:54
@mchowning mchowning requested a review from a team as a code owner December 1, 2023 13:54
@mchowning mchowning added this to the 7.53 ❄️ milestone Dec 1, 2023
@mchowning mchowning added the [Type] Bug Not functioning as intended. label Dec 1, 2023
@pocketcasts
Copy link

1 Warning
⚠️ This PR is assigned to the milestone 7.53 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@ashiagr ashiagr merged commit d739891 into release/7.53 Dec 1, 2023
10 checks passed
@ashiagr ashiagr deleted the revert/database-null-workaround branch December 1, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants