Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bookmarks tab order #1574

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 30, 2023

Description

This changes the Bookmarks tab position so that it is shown after the Chapters tab.
(Internal Ref: p1701267305022489/1701225559.781909-slack-C055BDMU095)

Testing Instructions

  1. Launch the app
  2. Play a podcast with chapters like https://pca.st/kfyb6kvc
  3. Open the full screen player
  4. ✅ Verify the order of the tabs is: Now Playing, Details, Chapters, Bookmarks

Screenshots or Screencast

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the 7.53 ❄️ milestone Nov 30, 2023
@ashiagr ashiagr requested a review from a team as a code owner November 30, 2023 04:48
@pocketcasts
Copy link

1 Warning
⚠️ This PR is assigned to the milestone 7.53 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me!

@ashiagr ashiagr merged commit ae2ac77 into release/7.53 Nov 30, 2023
@ashiagr ashiagr deleted the task/bookmarks-change-tab-order branch November 30, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants