Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback2023 - UI design feedback #1554

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 20, 2023

📘 Part of: #1463

Description

This addresses quick Playback2023 UI feedback (pdeCcb-3NF-p2)

  1. Top 5 shows - Replace publisher with total listening time for the show cbb6098
  2. Autoplay speed - Update to 7 seconds 9e4ba1d
  3. Total listening time - Removed the “.” at the end of the heading d6b4e86
  4. Top 4 categories -
    • Add a question mark “?” at the end of the heading d6b4e86
    • Font Size - Incremented so that they still appear correctly on Tablet bff76bc
      [No changes to Weight(Category Title W500, Category SubTitle W600), Font (DM Sans)]
  5. Number of shows & episodes - Distance between each artwork made more even 41d5230
  6. Button styles - Updated for Play now and Upsell buttons d247af8
  7. Plus stories - Improved subscription badge text color 1a90cd4
  8. Year over Year story - Improvements to “2022” and “2023” texts 17981bd

Testing Instructions

  1. Log in to an account that has a few episodes listened this year and last year
  2. Go to Profile and tap the End of Year card
  3. ✅ Notice that each of the above feedback is addressed

Screenshots or Screencast

1. Top 5 shows 3. Total listening time 4. Top 4 categories
4. Top 4 categories - Tablet - Nexus 9 (normal display)
6. Button Style 7. Subscription Badge 8. Year over Year story

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the 7.52 ❄️ milestone Nov 20, 2023
@ashiagr ashiagr requested a review from a team as a code owner November 20, 2023 06:57
@pocketcasts
Copy link

1 Warning
⚠️ This PR is assigned to the milestone 7.52 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@CookieyedCodes
Copy link

With 1. You sure we can't have a top 7 or top 10 😅, I do appreciate the times being included tho 😁

@mchowning
Copy link
Contributor

With 1. You sure we can't have a top 7 or top 10 😅

We'll consider it for next year, but for this year we're sticking with 5.

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the updates look great! 👍

@mchowning mchowning merged commit e00ce01 into release/7.52 Nov 20, 2023
@mchowning mchowning deleted the fix/playback2023-ui-design-feedback branch November 20, 2023 14:49
@david-gonzalez-a8c
Copy link

With 1. You sure we can't have a top 7 or top 10 😅, I do appreciate the times being included tho 😁

Hey @CookieyedCodes. David here, I worked on these designs.

We went with a top 5 to keep this a bit cleaner and not so information-heavy. A top 10 felt a bit cluttered, specially on smaller screens. However, we are thinking about adding permanent, more comprehensive stats in other places of the app.

Thanks for your comments ✨

@CookieyedCodes
Copy link

CookieyedCodes commented Nov 23, 2023

@david-gonzalez-a8c understandable & I don't completely disagree I do feel like 5 is still limiting because you should dare to give more podcast information then Spotify, anywho I look forward to to more stats 😀

Did you see my rough designs I did on the slack(look under watch 😉) /this GitHub discussion https://github.com/Automattic/pocket-casts-android/discussions/1452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants