Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bookmark incremental sync when delete is null #1552

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 17, 2023

Description

This allows incremental sync of bookmarks when the delete value is null.

Testing Instructions

  1. Add a breakpoint at line 254 in SyncUpdateResponseParser.kt
  2. Install debug app from this branch
  3. Login into web staging server and debug app with the same Plus account.
  4. Create a bookmark for an episode on the web (it is important that bookmark is created after login into the app to test incremental syncing)
  5. Enable debugging for the app
  6. Tap Refresh now under Profile in the app
  7. Make sure that breakpoint added at step 1 is hit
  8. Resume from debugging
  9. Open the episode in the app to which bookmark was added in step 4
  10. Switch to bookmarks tab
  11. ✅ Notice that the bookmark added at step 4 is displayed

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the 7.52 ❄️ milestone Nov 17, 2023
@ashiagr ashiagr requested a review from a team as a code owner November 17, 2023 13:15
@pocketcasts
Copy link

1 Warning
⚠️ This PR is assigned to the milestone 7.52 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync from web is now working great! Good job tracking this fix down!

@mchowning mchowning merged commit eb219e9 into release/7.52 Nov 17, 2023
@mchowning mchowning deleted the fix/bookmarks-incremental-sync branch November 17, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants