Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2023: prompt user to share when a screenshot is taken #1527

Closed
wants to merge 2 commits into from

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 8, 2023

📘 Part of: #1463

Detects when a user takes a screenshot and displays an alert.

Testing Instructions

  1. Make sure you're logged in to an account that has a few episodes listened to this year and last year
  2. Go to Profile
  3. Open stories
  4. Notice you get permission to read photos
  5. Allow permission
  6. When stories are loaded, take a screenshot
  7. ✅ You should see an alert and the stories should pause
  8. Tap "Not now"
  9. ✅ Stories should resume
  10. Take another screenshot
  11. Tap "Share"
  12. ✅ The share sheet should appear
  13. Dismiss it
  14. ✅ Stories should resume
  15. Take another screenshot
  16. Tap "Share"
  17. Share the story from the share sheet that appears
  18. ✅ Hashtags and share text should be present on the shared story

** It might be good to test on Android 12, Android 13, and Android 14 devices.

Screenshots or Screencast

Android 12 Android 13

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Nov 8, 2023
@ashiagr ashiagr marked this pull request as ready for review November 8, 2023 11:43
@ashiagr ashiagr requested a review from a team as a code owner November 8, 2023 11:43
@ashiagr ashiagr mentioned this pull request Nov 8, 2023
25 tasks
@pocketcasts
Copy link

1 Error
🚫 Please add tests for class ScreenshotDetector (or add unit-tests-exemption label to ignore this).

Generated by 🚫 Danger

@ashiagr
Copy link
Contributor Author

ashiagr commented Nov 10, 2023

Closing this PR as per internal discussion: p1699615565224589/1699481796.875689-slack-C041BGTFQ5R

@ashiagr ashiagr closed this Nov 10, 2023
@ashiagr ashiagr deleted the task/1483-screenshot-share-alert branch April 12, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants