Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2023 - Improvements #1524

Merged
merged 17 commits into from
Nov 8, 2023
Merged

Playback 2023 - Improvements #1524

merged 17 commits into from
Nov 8, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 7, 2023

📘 Part of: #1463

Description

Testing Instructions

Update the share copies, hashtag, add app logo

  • Run the app on a real device
  • Make sure you're logged in to an account that has a few episodes listened to this year and last year
  • Go to Profile
  • Open stories
  • Test sharing each story
  • ✅ #playback2023 hashtag should be shared
  • ✅ Double-check the text content
  • ✅ Check that shared images have app logo
  • ✅ Double-check the text content
Hash tag Shared image with logo

Fix text cutoff in year over year story, Update epilogue button style, Update percentage in the completion story

  • Edit EndOfYearManagerImpl to return
    YearOverYearListeningTime(totalPlayedTimeThisYear = 10000, totalPlayedTimeLastYear = 0,) for StoryYearOverYear at line 166
    EpisodesStartedAndCompleted(started = 0, completed = 0) for StoryCompletionRate at line 167
  • Make sure you're logged in to Plus account that has a few episodes listened to this year and last year
  • Go to Profile
  • Open stories
  • Go to top category story
  • ✅ Check that the top category story has appropriate newlines for english lang.
  • Go to year over year story
  • ✅ Check that text is not cutoff in year over year story when there is a huge decrease/ increase in the listening time
  • Go to completion rate story
  • ✅ Check percentage is zero when no episode was started
  • Go to epilogue story
  • ✅ Check that "Play again" button looks good
  • ✅ Check that when you tap between stories, title remain stable (except on Plus story it it moves below the subscription badge)
Top Category Year over Year Completion Rate Epilogue

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Nov 7, 2023
@ashiagr ashiagr mentioned this pull request Nov 7, 2023
25 tasks
GROUP BY podcast_id
ORDER BY totalPlayedTime DESC, numberOfPlayedEpisodes DESC
LIMIT :limit
SELECT (totalPlayedTime * 0.4) * (numberOfPlayedEpisodes * 0.6) as weighted, * FROM (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches iOS query: Automattic/pocket-casts-ios@844bd08 for top podcast

Slack discussion: p1698773178757819-slack-C041BGTFQ5R

@ashiagr ashiagr marked this pull request as ready for review November 7, 2023 13:23
@ashiagr ashiagr requested a review from a team as a code owner November 7, 2023 13:23
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, these are some good improvements!

Base automatically changed from task/1463-tracks to main November 8, 2023 06:50
@ashiagr ashiagr enabled auto-merge (squash) November 8, 2023 08:17
@pocketcasts
Copy link

1 Warning
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@ashiagr ashiagr merged commit 99b63c8 into main Nov 8, 2023
@ashiagr ashiagr deleted the task/1463-misc branch November 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants