-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2023 - Improvements #1524
Conversation
(To get more bottom space and so that title doesn't jump between screen)
GROUP BY podcast_id | ||
ORDER BY totalPlayedTime DESC, numberOfPlayedEpisodes DESC | ||
LIMIT :limit | ||
SELECT (totalPlayedTime * 0.4) * (numberOfPlayedEpisodes * 0.6) as weighted, * FROM ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches iOS query: Automattic/pocket-casts-ios@844bd08 for top podcast
Slack discussion: p1698773178757819-slack-C041BGTFQ5R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, these are some good improvements!
Generated by 🚫 Danger |
Description
Testing Instructions
Update the share copies, hashtag, add app logo
Fix text cutoff in year over year story, Update epilogue button style, Update percentage in the completion story
YearOverYearListeningTime(totalPlayedTimeThisYear = 10000, totalPlayedTimeLastYear = 0,)
forStoryYearOverYear
at line 166EpisodesStartedAndCompleted(started = 0, completed = 0)
forStoryCompletionRate
at line 167Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...