Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2023: Tracks #1523

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Playback 2023: Tracks #1523

merged 7 commits into from
Nov 8, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 7, 2023

📘 Part of: #1463

Description

Adds event when showing the stories upsell

Testing Instructions

  • Enable EoY Year for release build
  • Release build
  • License test account
  1. Make sure you're logged in to a free account that has a few episodes listened to this year and last year
  2. Go to Profile
  3. Open stories
  4. Go to the year over year story
  5. ✅ Check that end_of_year_upsell_shown is tracked and end_of_year_story_shown properties {"story": "year_over_year"} is not
  6. Tap upsell button
  7. Check that plus_promotion_shown properties {"flow": "plus_upsell, "source": "end_of_year"} is shown.
  8. Purchase
  9. ✅ Check that end_of_year_story_shown ["story": "year_over_year"] is shown
  10. Go to next story
  11. ✅ Check that end_of_year_story_shown ["story": "completion_rate"] is shown

At step 7. iOS displays
plus_promotion_shown ["flow": "endOfYearUpsell", "source": "endOfYear"]
I am not sure if we need to specify a separate flow for end of year, given that we also display end of year source. Lmkwyt.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner November 7, 2023 05:51
@ashiagr ashiagr mentioned this pull request Nov 7, 2023
25 tasks
@ashiagr ashiagr added this to the Future milestone Nov 7, 2023
@mchowning
Copy link
Contributor

I am not sure if we need to specify a separate flow for end of year, given that we also display end of year source.

Unless there's some specific reason we need the flow as well (i.e., there are different flows that can happen from the end of year source), I wouldn't add the additional flow.

Base automatically changed from task/1463-sync-last-year to main November 8, 2023 05:34
@ashiagr ashiagr enabled auto-merge (squash) November 8, 2023 06:15
@ashiagr ashiagr merged commit e54c5c7 into main Nov 8, 2023
@ashiagr ashiagr deleted the task/1463-tracks branch November 8, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants