Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds event when showing the stories upsell
Testing Instructions
end_of_year_upsell_shown
is tracked andend_of_year_story_shown properties {"story": "year_over_year"}
is notplus_promotion_shown properties {"flow": "plus_upsell, "source": "end_of_year"}
is shown.end_of_year_story_shown ["story": "year_over_year"]
is shownend_of_year_story_shown ["story": "completion_rate"]
is shownAt step 7. iOS displays
plus_promotion_shown ["flow": "endOfYearUpsell", "source": "endOfYear"]
I am not sure if we need to specify a separate flow for end of year, given that we also display end of year source. Lmkwyt.
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...