-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2023: Plus Upsell story #1516
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the test steps work as described and the code looks good. 👍
It feels a bit odd to me that we pause the stories on the upsell. I imagine that is going to significantly reduce the number of people who get to the Thank You screen since a lot of people may not even realize that you can tap the sides to advance. I realize that isn't a decision you made, so I'm just sharing that as feedback in case there's any more discussion around it.
Description
Adds paid wall view for Plus Upsell story
Testing Instructions
PaidStoryWallView.kt
previews)Screenshots or Screencast
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...