Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback 2023: Plus Upsell story #1516

Merged
merged 11 commits into from
Nov 3, 2023
Merged

Playback 2023: Plus Upsell story #1516

merged 11 commits into from
Nov 3, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 3, 2023

📘 Part of: #1463 🎨 Designs: lH66LwxxgG8btQ8NrM0ldx-fi-1599_20385

Description

Adds paid wall view for Plus Upsell story

Testing Instructions

  1. Make sure you're logged in to an account that has a few episodes listened
  2. Go to Profile
  3. Tap the EOY image
  4. Skip to the 1st Plus story
  5. ✅ Notice you see Upsell button with a blurred background
  6. ✅ Notice that Upsell button title is shown correctly based on free trial for Plus (this can also be checked in PaidStoryWallView.kt previews)
  7. ✅ Notice that story is paused
  8. ✅ Notice that tapping on left on this Upsell story should take to the previous free story
  9. ✅ Notice that tapping on right on this Upsell story should take to the epilogue story skipping plus stories in between
  10. ✅ Notice that tapping on close button on this Upsell story should dismiss the stories modal

Screenshots or Screencast

Upsell

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the Future milestone Nov 3, 2023
@ashiagr ashiagr marked this pull request as ready for review November 3, 2023 12:00
@ashiagr ashiagr requested a review from a team as a code owner November 3, 2023 12:00
@pocketcasts
Copy link

1 Warning
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@ashiagr ashiagr mentioned this pull request Nov 3, 2023
25 tasks
Base automatically changed from task/extract-free-trial-logic to main November 3, 2023 14:21
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the test steps work as described and the code looks good. 👍

It feels a bit odd to me that we pause the stories on the upsell. I imagine that is going to significantly reduce the number of people who get to the Thank You screen since a lot of people may not even realize that you can tap the sides to advance. I realize that isn't a decision you made, so I'm just sharing that as feedback in case there's any more discussion around it.

@mchowning mchowning merged commit 8401052 into main Nov 3, 2023
@mchowning mchowning deleted the task/1463-plus-paid-wall branch November 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants