Playback 2023: Skip "Plus stories" in sequence #1512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to:
Basically — given the "Plus stories" will have an upsell, we don't want users to see the same story multiple times. So we just display it once, whether is going to next stories or previous one.
To test
Before testing, add
override val plusOnly: Boolean = true
inStoryYearOverYear
andStoryCompletionRate
.Note that the first plus story "StoryYearOverYear" doesn't have an upsell yet.
Then:
Free
accountPlus
plan to accountPatron
plan to account** Tests cover skip scenarios when there are multiple plus stories in between
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...