Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct EOY banner to use onboarding flow #1500

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

mchowning
Copy link
Contributor

Description

This makes it so that the EOY banner uses the onboarding flow instead of the old AccountActivity sign in screen.

Related to #1499 (but does not entirely fix that issue since we still have AccountActivity code in other places).

Testing Instructions

  1. Fresh install the app
  2. Tap on the EOY banner on the profile screen
  3. ✅ Observe that you are taken to the OnboardingFlow sign in screen (easy to tell because this screen has a Google Sign In option whereas the old AccountActivity screen does not provide that option).
  4. Sign in
  5. ✅ Observe that after sign in you are taken to the EOY stories
  6. Exit the EOY stories
  7. Tap on the EOY banner again
  8. ✅ Observe that you are taken to the EOY stories

Video

Screen.Recording.2023-10-30.at.2.16.24.PM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning added this to the 7.52 milestone Oct 30, 2023
@mchowning mchowning requested a review from a team as a code owner October 30, 2023 18:17
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, thanks for this!

@ashiagr ashiagr merged commit aba228b into main Oct 31, 2023
@ashiagr ashiagr deleted the fix/eoy-banner-login-to-onboarding-flow branch October 31, 2023 04:14
@ashiagr ashiagr mentioned this pull request Nov 1, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants