Playback 2023 - Top listened categories story #1482
Conversation
This is done so that subtitle is visible over blue area. Also added alpha to blurred background to lighten it.
This is done to avoid crash in another language which still have two dynamic strings
# Conflicts: # modules/features/endofyear/src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/views/stories/StoryTopPodcastView.kt # modules/services/localization/src/main/res/values/strings.xml # modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/endofyear/EndOfYearManagerImpl.kt
| ) { | ||
| Image( | ||
| painterResource(id = R.drawable.story_blurred_background), | ||
| contentDescription = null, | ||
| contentScale = ContentScale.Crop, | ||
| modifier = Modifier.fillMaxSize() | ||
| .alpha(0.6f) |
There was a problem hiding this comment.
I added alpha to the blurred background as those looked brighter than Figma backgrounds. This has also improved the readability of the title on the "Top Podcast" story. Let me know if you have other ideas.
| Before | After |
|---|---|
 |
 |
|
|
||
| private const val BackgroundColor = 0xFF744F9D | ||
| private val CategoryColor = Color(0xFF686C74) | ||
| private val CategoryFontSize = 40.sp |
There was a problem hiding this comment.
I reduced the font size for the categories so that they fit well on different display sizes and on tablets.
| @@ -1592,7 +1600,7 @@ | |||
| <!-- Text that appear when someone share the listened numbers story to Twitter. %1$d is a placeholder for the number of podcasts listened and %2$d for the number of episodes. --> | |||
| <string name="end_of_year_story_listened_to_numbers_share_text">I listened to %1$d different podcasts and %2$d episodes in 2022</string> | |||
| <!-- Title for the story that display the most listened podcast by the user this year. %1$s is a placeholder for the podcast title and %2$s is a placeholder for the author. --> | |||
| <string name="end_of_year_story_top_podcast">%1$s was your most listened show in 2023</string> | |||
| <string name="end_of_year_story_top_podcast_title">%1$s was your most listened show in 2023</string> | |||
There was a problem hiding this comment.
Be careful in reviewing string updates as the older strings may have different placeholder counts in translations that could cause a crash.
There was a problem hiding this comment.
Thanks for mentioning this. I wouldn't have thought about it, and now I'll be more careful.
| @@ -338,7 +338,9 @@ abstract class EpisodeDao { | |||
|
|
|||
| @Query( | |||
| """ | |||
| SELECT DISTINCT podcast_episodes.uuid as episodeId, COUNT(DISTINCT podcast_id) as numberOfPodcasts, SUM(played_up_to) as totalPlayedTime, | |||
| SELECT DISTINCT podcast_episodes.uuid as episodeId, COUNT(DISTINCT podcast_id) as numberOfPodcasts, | |||
There was a problem hiding this comment.
nitpick, but I think it would help readability to put the episodeId and numberOfPodcasts on separate lines like we have with the other parameters. Same with the mostListenedPodcastId and mostListenedPodcastTintColor on line 345.
Certainly not a blocker.
There was a problem hiding this comment.
Good point, updated in 5a0363c
Description
Adds the 2023 visual for the Top Categories Story.
Testing Instructions
Screenshots or Screencast
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...