-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback 2023 - Top five podcasts story #1481
Conversation
Still think it should be more then a top 5 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, @CookieyedCodes! It has been communicated to the team. While it might be difficult to fit 10-15 top podcasts on this screen, we're considering showing them in the Stats section. |
I realized that in my next PR where I rotated the blurred image (037f068) to get more contrast behind the text. I'll update the background for this story as well there. |
# Conflicts: # modules/features/endofyear/src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/views/stories/StoryTopPodcastView.kt
@ashiagr fair enough, I only request it because your podcast theamed end of year should be better then Spotifys 😅, more stats would allways be welcome 😁 |
Description
Adds the 2023 visual for the Top Podcasts Story.
Testing Instructions
Screenshots or Screencast
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...