Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 7.47-rc-2 to main #1351

Merged
merged 29 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e620d2a
Bump version number
mchowning Aug 21, 2023
d4f7210
Update draft release notes for 7.46.
mchowning Aug 21, 2023
5a76554
Release Notes: add new section for next version (7.47)
mchowning Aug 21, 2023
1bd53d0
Avoid crash when accessing and dismissing episode details from up nex…
mchowning Aug 22, 2023
3567dae
Bump version number
mchowning Aug 22, 2023
4bd33e3
Make sure that we're batching multiselect updates
mchowning Aug 28, 2023
27e1e7c
Update changelog
mchowning Aug 28, 2023
fffd47e
Update version code
ashiagr Aug 29, 2023
85eab18
Bump version number
ashiagr Aug 29, 2023
f5a948a
Use transaction when archiving multiple episodes (#1327)
mchowning Sep 1, 2023
ecfef17
Bump version number
ashiagr Sep 1, 2023
5d936d0
Temporary fix for notification permission checker (#1325)
ashiagr Sep 2, 2023
a9b3e76
Remove previous toolbar action observers when adding a new one (#1333)
mchowning Sep 2, 2023
7ac3ba0
Bump version number
ashiagr Sep 2, 2023
a627679
Update translations
ashiagr Sep 2, 2023
20c4662
Bump version number
ashiagr Sep 4, 2023
a590f64
Update draft release notes for 7.47.
ashiagr Sep 4, 2023
448802b
Release Notes: add new section for next version (7.48)
ashiagr Sep 4, 2023
0f2c26c
Update cloud storage limit title (#1342)
ashiagr Sep 5, 2023
c317b69
Bump version number
ashiagr Sep 6, 2023
feed2ec
Update multi select toolbars setup (#1350)
ashiagr Sep 6, 2023
7db2f29
Merge branch 'release/7.46.1' into release/7.47
ashiagr Sep 6, 2023
50269b2
Fix formatting
ashiagr Sep 6, 2023
41ff982
Add Sentry breadcrumbs when toolbar actions change (#1344)
mchowning Sep 6, 2023
5865f3c
Merge branch 'release/7.47' of https://github.com/Automattic/pocket-c…
ashiagr Sep 6, 2023
e9d2665
Bump version
ashiagr Sep 6, 2023
15aeb53
Bump version number
ashiagr Sep 6, 2023
4b31e52
Merge branch 'main' into merge/release-7.47-rc-2-to-main
ashiagr Sep 6, 2023
9db22c3
Reinsert changelog entry that got removed during merge
mchowning Sep 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,20 @@
([#1312](https://github.com/Automattic/pocket-casts-android/pull/1312))
* Present app review prompt
([#1305](https://github.com/Automattic/pocket-casts-android/pull/1305))
* Updated storage limit title
([#1342](https://github.com/Automattic/pocket-casts-android/pull/1342))
* Bug Fixes:
* Fixed auto archive settings getting lost when switching languages
([#1234](https://github.com/Automattic/pocket-casts-android/pull/1234))
* Improved handling of enabling/disabling new episode notifications
([#1264](https://github.com/Automattic/pocket-casts-android/pull/1264))
* Fixed the artwork not appearing on the onboarding page
([#1299](https://github.com/Automattic/pocket-casts-android/pull/1299))
* Improved multi-select toolbars setup

7.46.1
------
* Bug Fixes:
* Improved multi-select toolbars setup
([#1338](https://github.com/Automattic/pocket-casts-android/pull/1338))

7.46
Expand All @@ -41,7 +47,7 @@
7.45.1
-----
* Bug Fixes:
* Fixed issue where that could cause app freeze when using multiselect
* Fixed issue that could cause app freeze when using multiselect
([#1315](https://github.com/Automattic/pocket-casts-android/pull/1315))

7.45
Expand Down
5 changes: 1 addition & 4 deletions metadata/release_notes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
([#1298](https://github.com/Automattic/pocket-casts-android/pull/1298))
* Present toast notification when duration of an in-progress episode changes
([#1312](https://github.com/Automattic/pocket-casts-android/pull/1312))
* Present app review prompt
* Present app review prompt
([#1305](https://github.com/Automattic/pocket-casts-android/pull/1305))
* Bug Fixes:
* Fixed auto archive settings getting lost when switching languages
Expand All @@ -13,6 +13,3 @@
([#1264](https://github.com/Automattic/pocket-casts-android/pull/1264))
* Fixed the artwork not appearing on the onboarding page
([#1299](https://github.com/Automattic/pocket-casts-android/pull/1299))
* Improved multi-select toolbars setup
([#1338](https://github.com/Automattic/pocket-casts-android/pull/1338))

Original file line number Diff line number Diff line change
Expand Up @@ -1655,7 +1655,7 @@
<string name="onboarding_plus_feature_desktop_apps_text">Listen in more places with our Windows, macOS, and Web apps.</string>
<string name="onboarding_plus_feature_folders_title">Folders</string>
<string name="onboarding_plus_feature_folders_text">Organize your podcasts in folders and keep them in sync across all your devices.</string>
<string name="onboarding_plus_feature_cloud_storage_title">10GB Cloud Storage</string>
<string name="onboarding_plus_feature_cloud_storage_title">20GB Cloud Storage</string>
<string name="onboarding_plus_feature_cloud_storage_text">Upload your files to cloud storage and have them available everywhere.</string>
<string name="onboarding_plus_feature_watch_playback">Watch Playback</string>
<string name="onboarding_plus_feature_extra_themes_icons_title">Extra Themes &amp; App Icons</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import au.com.shiftyjelly.pocketcasts.models.entity.Bookmark
import au.com.shiftyjelly.pocketcasts.repositories.bookmark.BookmarkManager
import au.com.shiftyjelly.pocketcasts.views.R
import au.com.shiftyjelly.pocketcasts.views.dialog.ConfirmationDialog
import io.sentry.Sentry
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.MutableSharedFlow
import kotlinx.coroutines.flow.asSharedFlow
Expand All @@ -35,6 +36,7 @@ class MultiSelectBookmarksHelper @Inject constructor(

override val toolbarActions: LiveData<List<MultiSelectAction>> = _selectedListLive
.map {
Sentry.addBreadcrumb("MultiSelectBookmarksHelper toolbarActions updated, ${it.size} bookmarks from $source")
listOf(
MultiSelectBookmarkAction.EditBookmark(isVisible = it.count() == 1),
MultiSelectBookmarkAction.DeleteBookmark,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import au.com.shiftyjelly.pocketcasts.views.dialog.ShareDialog
import au.com.shiftyjelly.pocketcasts.views.helper.CloudDeleteHelper
import au.com.shiftyjelly.pocketcasts.views.helper.DeleteState
import io.reactivex.BackpressureStrategy
import io.sentry.Sentry
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
Expand Down Expand Up @@ -59,6 +60,7 @@ class MultiSelectEpisodesHelper @Inject constructor(
.toLiveData()
.combineLatest(_selectedListLive)
.map { (actions, selectedEpisodes) ->
Sentry.addBreadcrumb("MultiSelectEpisodesHelper toolbarActions updated (${actions.size}): ${actions.map { it::class.java.simpleName }}, ${selectedEpisodes.size} selectedEpisodes from $source")
actions.mapNotNull {
MultiSelectEpisodeAction.actionForGroup(it.groupId, selectedEpisodes)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import au.com.shiftyjelly.pocketcasts.ui.extensions.getThemeColor
import au.com.shiftyjelly.pocketcasts.views.R
import au.com.shiftyjelly.pocketcasts.views.extensions.tintIcons
import dagger.hilt.android.AndroidEntryPoint
import io.sentry.Sentry
import javax.inject.Inject
import au.com.shiftyjelly.pocketcasts.images.R as IR
import au.com.shiftyjelly.pocketcasts.localization.R as LR
Expand Down Expand Up @@ -44,6 +45,9 @@ class MultiSelectToolbar @JvmOverloads constructor(
} else {
multiSelectHelper.toolbarActions.removeObservers(lifecycleOwner)
multiSelectHelper.toolbarActions.observe(lifecycleOwner) {

Sentry.addBreadcrumb("MultiSelectToolbar setup observed toolbarActionChange,$it from ${multiSelectHelper.source}")

menu.clear()

val maxIcons = multiSelectHelper.maxToolbarIcons
Expand Down
4 changes: 2 additions & 2 deletions version.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Version Information for Vanilla / Release builds
versionName=7.47-rc-1
versionCode=9136
versionName=7.47-rc-2
versionCode=9139