Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloud storage limit title #1342

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Sep 5, 2023

Description

This updates cloud storage string title from 10GB to 20GB.

This targets v7.47 beta branch.

We should probably add a task to update this title dynamically from the remote config.

Testing Instructions

It should be sufficient to just check the strings file.

Screenshots or Screencast

Old New

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added this to the 7.47 ❄️ milestone Sep 5, 2023
@ashiagr ashiagr requested a review from a team as a code owner September 5, 2023 05:14
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll hold off on cutting a new beta since this is a relatively trivial change. Let me know if you think we should go ahead and cut a new beta though.

@mchowning mchowning merged commit 0f2c26c into release/7.47 Sep 5, 2023
@mchowning mchowning deleted the task/update-cloud-storage branch September 5, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants